Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/e2e-test-pipeline #15

Merged
merged 32 commits into from
Apr 17, 2024
Merged

feat/e2e-test-pipeline #15

merged 32 commits into from
Apr 17, 2024

Conversation

Fovty
Copy link
Member

@Fovty Fovty commented Apr 12, 2024 •
edited
Loading

Problem to solve

Creating a fully functional e2e pipeline

Proposal

Clone sparrow e2e pipeline and adapt it accordingly

Who can address the issue

  • GitHub actions knowledge
  • Kubernetes, Helm

Other links/references

@Fovty Fovty changed the title fix: different tags for images test/actions-pr Apr 12, 2024
@Fovty Fovty changed the title test/actions-pr feat/e2e-test-pipeline Apr 15, 2024
@Fovty Fovty self-assigned this Apr 15, 2024
@Fovty Fovty added the feature label Apr 15, 2024
@Fovty Fovty requested review from puffitos and eumel8 April 15, 2024 12:28
@eumel8
trigger rebuild
c81b229 
Signed-off-by: Frank Kloeker <[email protected]>
eumel8
eumel8 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@eumel8 eumel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fovty Fovty mentioned this pull request Apr 16, 2024
Closed
puffitos
puffitos approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@puffitos puffitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please open an issue regarding my reviews.

We shouldn't build a latest image in the main branch, as the main branch doesn't always need to be fully functional, and directly tagging something with latest means that it will get pulled automatically by various runtimes. The latest image (as well as a properly versioned image) should be produced when git tags are created.

chart/values.yaml Show resolved Hide resolved
.github/workflows/docker-build.yml Show resolved Hide resolved
@Fovty Fovty mentioned this pull request Apr 16, 2024
Closed
@puffitos
Copy link
Member

@jonathan-mayer @JTaeuber waiting on your approval here, when you got some time.

@Fovty Thanks for creating the issue 👍

JTaeuber
JTaeuber approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@JTaeuber JTaeuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fovty Fovty merged commit 5c5c095 into main Apr 17, 2024
2 checks passed
@Fovty Fovty deleted the test/action-pr branch April 17, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTaeuber JTaeuber JTaeuber approved these changes

@puffitos puffitos puffitos approved these changes

@eumel8 eumel8 eumel8 approved these changes

@jonathan-mayer jonathan-mayer Awaiting requested review from jonathan-mayer jonathan-mayer is a code owner

Assignees

@Fovty Fovty

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fovty @puffitos @eumel8 @JTaeuber